linux-kernel - Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zr9nW-rIA0TpmYVj@smile.fi.intel.com>
Date: Fri, 16 Aug 2024 17:51:07 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Ding, Shenghao" <shenghao-ding@...com>
Cc: "broonie@...nel.org" <broonie@...nel.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"perex@...ex.cz" <perex@...ex.cz>,
	"pierre-louis.bossart@...ux.intel.com" <pierre-louis.bossart@...ux.intel.com>,
	"13916275206@....com" <13916275206@....com>,
	"zhourui@...qin.com" <zhourui@...qin.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"Salazar, Ivan" <i-salazar@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Chadha, Jasjot Singh" <j-chadha@...com>,
	"liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
	"Yue, Jaden" <jaden-yue@...com>,
	"yung-chuan.liao@...ux.intel.com" <yung-chuan.liao@...ux.intel.com>,
	"Rao, Dipa" <dipa@...com>,
	"yuhsuan@...gle.com" <yuhsuan@...gle.com>,
	"Lo, Henry" <henry.lo@...com>, "tiwai@...e.de" <tiwai@...e.de>,
	"Xu, Baojun" <baojun.xu@...com>,
	"Baojun.Xu@....com" <Baojun.Xu@....com>,
	"judyhsiao@...gle.com" <judyhsiao@...gle.com>,
	"Navada Kanyana, Mukund" <navada@...com>,
	"cujomalainey@...gle.com" <cujomalainey@...gle.com>,
	"Kutty, Aanya" <aanya@...com>,
	"Mahmud, Nayeem" <nayeem.mahmud@...com>,
	"savyasanchi.shukla@...radyne.com" <savyasanchi.shukla@...radyne.com>,
	"flaviopr@...rosoft.com" <flaviopr@...rosoft.com>,
	"Ji, Jesse" <jesse-ji@...com>,
	"darren.ye@...iatek.com" <darren.ye@...iatek.com>,
	"antheas.dk@...il.com" <antheas.dk@...il.com>,
	"Jerry2.Huang@...uturecenter.com" <Jerry2.Huang@...uturecenter.com>
Subject: Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Rename dai_driver name
 to unify the name between TAS2563 and TAS2781

On Fri, Aug 16, 2024 at 01:41:46PM +0000, Ding, Shenghao wrote:
> > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Sent: Thursday, August 15, 2024 8:04 PM
> > To: Ding, Shenghao <shenghao-ding@...com>
> > On Thu, Aug 15, 2024 at 03:02:01AM +0000, Ding, Shenghao wrote:
> > > > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > > Sent: Monday, August 12, 2024 11:52 PM On Sat, Aug 03, 2024 at
> > > > 11:27:14AM +0800, Shenghao Ding wrote:

...

> > > > > +	strscpy(name, "Speaker Profile Id",
> > > > SNDRV_CTL_ELEM_ID_NAME_MAXLEN);
> > > >
> > > > > +	strscpy(prog_name, "Speaker Program Id",
> > > > > +		SNDRV_CTL_ELEM_ID_NAME_MAXLEN);
> > > >
> > > > > +	strscpy(conf_name, "Speaker Config Id",
> > > > > +SNDRV_CTL_ELEM_ID_NAME_MAXLEN);
> > > >
> > > > Why not 2-parameter strscpy()?
> > > strscpy seemed not support 2 params. Do you mean strcpy?
> > 
> > 1. It does.
> > 2. No, I meant strscpy().
> I have tried 2-parameter strscpy(), and occurred compiling issue.
> The first parameter of strscpy, *dst, must be array, but in this code
> prog_name and conf_name are points to the memories applied by
> devm_kcalloc.

Okay, I'm not sure why devm_kasprintf() is not used for these cases.

-- 
With Best Regards,
Andy Shevchenko