linux-kernel - Re: [PATCH v4 04/10] power: supply: max77693: Set charge current limits during init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f91048f3-2a97-493f-a35c-0e8f184d77d6@kernel.org>
Date: Fri, 16 Aug 2024 17:40:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Artur Weber <aweber.kernel@...il.com>,
 Chanwoo Choi <cw00.choi@...sung.com>
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Alim Akhtar <alim.akhtar@...sung.com>, linux-pm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 ~postmarketos/upstreaming@...ts.sr.ht, Henrik Grimler <henrik@...mler.se>,
 Wolfgang Wiedmeyer <wolfgit@...dmeyer.de>,
 Denis 'GNUtoo' Carikli <GNUtoo@...erdimension.org>
Subject: Re: [PATCH v4 04/10] power: supply: max77693: Set charge current
 limits during init

On 16/08/2024 16:25, Artur Weber wrote:
> 
> 
> On 16.08.2024 11:54, Krzysztof Kozlowski wrote:
>> On 16/08/2024 10:19, Artur Weber wrote:
>>> @@ -732,6 +794,15 @@ static int max77693_charger_probe(struct platform_device *pdev)
>>>   	chg->dev = &pdev->dev;
>>>   	chg->max77693 = max77693;
>>>   
>>> +	psy_cfg.drv_data = chg;
>>> +
>>> +	chg->charger = devm_power_supply_register(&pdev->dev,
>>> +						  &max77693_charger_desc,
>>> +						  &psy_cfg);
>>> +	if (IS_ERR(chg->charger))
>>> +		return dev_err_probe(&pdev->dev, PTR_ERR(chg->charger),
>>> +				     "failed: power supply register\n");
>>
>> This code move is not explained in the commit msg. At least I could not
>> find it. Please explain why you need it in the commit msg.
> 
> This is done because the call to power_supply_get_battery_info in
> max77693_dt_init requires chg->charger to be set. (I was considering
> putting this in the commit message, can't remember why I didn't do it.
> I'll add it in the next version.)

I think that's wrong. Power supply is being available to the system
before it is being configured.

Best regards,
Krzysztof