linux-kernel - Re: [PATCH v4 08/10] ARM: dts: samsung: exynos4212-tab3: Add battery node with charge current value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ekqydclwg6dx6ydqcm3tanyho636hxtwpx3cnpj7c4dwpdxa2d@bbzaqvkoajrg>
Date: Tue, 27 Aug 2024 18:51:52 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Artur Weber <aweber.kernel@...il.com>, 
	Chanwoo Choi <cw00.choi@...sung.com>, Rob Herring <robh@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, linux-pm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, 
	~postmarketos/upstreaming@...ts.sr.ht, Henrik Grimler <henrik@...mler.se>, 
	Wolfgang Wiedmeyer <wolfgit@...dmeyer.de>, Denis 'GNUtoo' Carikli <GNUtoo@...erdimension.org>
Subject: Re: [PATCH v4 08/10] ARM: dts: samsung: exynos4212-tab3: Add battery
 node with charge current value

Hi,

On Fri, Aug 16, 2024 at 12:03:32PM GMT, Krzysztof Kozlowski wrote:
> On 16/08/2024 10:19, Artur Weber wrote:
> > This value was verified by comparing register dumps of the MAX77693
> > charger with on mainline with a downstream kernel under Android; the
> > value on downstream was set to 1.8 amps when charging with a proper
> > charger.
> > 
> > Add it to a new battery node and pass it to the MAX77693 charger
> > so that the fast charge current setting can be used for charging.
> > 
> > Tested-by: Henrik Grimler <henrik@...mler.se>
> > Signed-off-by: Artur Weber <aweber.kernel@...il.com>
> > ---
> > Changes in v2:
> > - Switched to monitored-battery
> > ---
> >  arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> 
> For next version, please split DTS into separate patchset and provide in
> changelog (---) lore link to power supply patchset with bindings. It
> will be easier for Sebastian to apply entire set for psy.

I'm fine with a splitted series of course, but I am also perfectly
fine with applying partial patchsets. I know at least some SoC
maintainers like this style of a combined patch series, since they
basically get an automatic push notification that the dependencies
have been merged. It also makes testing easier of course :)

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)