linux-kernel - Re: [PATCH net-next v6 10/14] net: ethernet: oa_tc6: implement receive path to receive rx ethernet frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240816100147.0ed4acb6@kernel.org>
Date: Fri, 16 Aug 2024 10:01:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <horms@...nel.org>, <saeedm@...dia.com>, <anthony.l.nguyen@...el.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <andrew@...n.ch>,
 <corbet@....net>, <linux-doc@...r.kernel.org>, <robh+dt@...nel.org>,
 <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
 <devicetree@...r.kernel.org>, <horatiu.vultur@...rochip.com>,
 <ruanjinjie@...wei.com>, <steen.hegelund@...rochip.com>,
 <vladimir.oltean@....com>, <masahiroy@...nel.org>, <alexanderduyck@...com>,
 <krzk+dt@...nel.org>, <robh@...nel.org>, <rdunlap@...radead.org>,
 <hkallweit1@...il.com>, <linux@...linux.org.uk>,
 <UNGLinuxDriver@...rochip.com>, <Thorsten.Kummermehr@...rochip.com>,
 <Pier.Beruto@...emi.com>, <Selvamani.Rajagopal@...emi.com>,
 <Nicolas.Ferre@...rochip.com>, <benjamin.bigler@...nformulastudent.ch>,
 <linux@...ler.io>, <markku.vorne@...power.com>
Subject: Re: [PATCH net-next v6 10/14] net: ethernet: oa_tc6: implement
 receive path to receive rx ethernet frames

On Mon, 12 Aug 2024 15:56:07 +0530 Parthiban Veerasooran wrote:
> +	if (netif_rx(tc6->rx_skb) == NET_RX_DROP)
> +		tc6->netdev->stats.rx_dropped++;

This is a bit unusual. If the core decides to drop the packet it will
count the drop towards the appropriate statistic. The drivers generally
only count their own drops, and call netif_rx() without checking the
return value.