linux-kernel - Re: [PATCH net-next v6 13/14] microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240816100537.7457ba58@kernel.org>
Date: Fri, 16 Aug 2024 10:05:37 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <horms@...nel.org>, <saeedm@...dia.com>, <anthony.l.nguyen@...el.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <andrew@...n.ch>,
 <corbet@....net>, <linux-doc@...r.kernel.org>, <robh+dt@...nel.org>,
 <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
 <devicetree@...r.kernel.org>, <horatiu.vultur@...rochip.com>,
 <ruanjinjie@...wei.com>, <steen.hegelund@...rochip.com>,
 <vladimir.oltean@....com>, <masahiroy@...nel.org>, <alexanderduyck@...com>,
 <krzk+dt@...nel.org>, <robh@...nel.org>, <rdunlap@...radead.org>,
 <hkallweit1@...il.com>, <linux@...linux.org.uk>,
 <UNGLinuxDriver@...rochip.com>, <Thorsten.Kummermehr@...rochip.com>,
 <Pier.Beruto@...emi.com>, <Selvamani.Rajagopal@...emi.com>,
 <Nicolas.Ferre@...rochip.com>, <benjamin.bigler@...nformulastudent.ch>,
 <linux@...ler.io>, <markku.vorne@...power.com>
Subject: Re: [PATCH net-next v6 13/14] microchip: lan865x: add driver
 support for Microchip's LAN865X MAC-PHY

On Mon, 12 Aug 2024 15:56:10 +0530 Parthiban Veerasooran wrote:
> +static void
> +lan865x_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info)
> +{
> +	strscpy(info->driver, DRV_NAME, sizeof(info->driver));
> +	strscpy(info->bus_info, dev_name(netdev->dev.parent),
> +		sizeof(info->bus_info));
> +}
> +

Could you check if deleting this function has any effect?
Core should fill in the basic info automatically, modern
drivers usually only have to fill in FW version, if at all.

If without the callback ethtool -i doesn't report the right
info, please make sure SET_NETDEV_DEV() gets called.