linux-kernel - Re: [REGRESSION] critical target error, bisected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240816080604.GA7249@lst.de>
Date: Fri, 16 Aug 2024 10:06:04 +0200
From: hch <hch@....de>
To: Shinichiro Kawasaki <shinichiro.kawasaki@....com>
Cc: "Martin K. Petersen" <martin.petersen@...cle.com>,
	Chris Bainbridge <chris.bainbridge@...il.com>,
	"fengli@...rtx.com" <fengli@...rtx.com>, hch <hch@....de>,
	"axboe@...nel.dk" <axboe@...nel.dk>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [REGRESSION] critical target error, bisected

On Fri, Aug 16, 2024 at 07:59:52AM +0000, Shinichiro Kawasaki wrote:
> I also observed a different but similar failure symptom when I ran f2fs workload
> using a zoned TCMU device. I found that the trigger is the commit f874d7210d88
> ("scsi: sd: Keep the discard mode stable") that Chris found. After the commit,
> the device has unexpected non-zero values for the sysfs attributes
> queue/discard_max_bytes and queue/discard_max_hw_bytes. I found that Martin's
> fix avoids my failure symptom also. With the fix, the failure disappeared and
> the sysfs attribute have the expected value 0. Thanks!

Btw, zoned devices in all relevant standards can support discards,
despite it being rather pointless.  So we'll probably want to fix up
f2fs to handle that case correctly and not issue discards just to be on
the safe side.