linux-kernel - Re: [REGRESSION] critical target error, bisected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1c03c6bb-b05b-4052-8a75-c062ce3af28e@oracle.com>
Date: Fri, 16 Aug 2024 09:21:50 +0100
From: John Garry <john.g.garry@...cle.com>
To: "Martin K. Petersen" <martin.petersen@...cle.com>,
        Chris Bainbridge <chris.bainbridge@...il.com>
Cc: fengli@...rtx.com, hch@....de, axboe@...nel.dk, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION] critical target error, bisected

On 16/08/2024 04:56, Martin K. Petersen wrote:
> 
> Chris,
> 
>> [  195.647081] sd 0:0:0:0: [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
>> [  195.647093] sd 0:0:0:0: [sda] tag#0 Sense Key : Illegal Request [current]
>> [  195.647096] sd 0:0:0:0: [sda] tag#0 Add. Sense: Invalid command operation code
>> [  195.647099] sd 0:0:0:0: [sda] tag#0 CDB: Write same(16) 93 08 00 00 00 00 04 dd 42 f8 00 00 2d 48 00 00
>> [  195.647101] critical target error, dev sda, sector 81609464 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 0
> 
> I would appreciate if you could test the following patch.
> 
> Thanks!
> 

That solves the issue I was seeing on default scsi_debug, like this:

# mkfs.xfs -V
mkfs.xfs version 5.14.2
# mkfs.xfs /dev/sda
meta-data=/dev/sda               isize=512    agcount=4, agsize=22400 blks
          =                       sectsz=512   attr=2, projid32bit=1
          =                       crc=1        finobt=1, sparse=1, rmapbt=0
          =                       reflink=1    bigtime=0 inobtcount=0
data     =                       bsize=4096   blocks=89600, imaxpct=25
          =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0, ftype=1
log      =internal log           bsize=4096   blocks=1368, version=2
          =                       sectsz=512   sunit=0 blks, lazy-count=1
realtime =none                   extsz=4096   blocks=0, rtextents=0
[   29.399767] sd 0:0:0:0: [sda] tag#166 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[   29.401463] sd 0:0:0:0: [sda] tag#166 Sense Key : Illegal Request 
[current]
[   29.403072] sd 0:0:0:0: [sda] tag#166 Add. Sense: Invalid field in cdb
[   29.404076] sd 0:0:0:0: [sda] tag#166 CDB: Write same(16) 93 08 00
00 00 00 00 00 00 00 00 00 ff ff 00 00
[   29.405344] critical target error, dev sda, sector 0 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[   29.408127] sd 0:0:0:0: [sda] tag#167 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[   29.410054] sd 0:0:0:0: [sda] tag#167 Sense Key : Illegal Request 
[current]
[   29.413442] sd 0:0:0:0: [sda] tag#167 Add. Sense: Invalid field in cdb
[   29.414552] sd 0:0:0:0: [sda] tag#167 CDB: Write same(16) 93 08 00
00 00 00 00 00 ff ff 00 00 ff ff 00 00
[   29.416241] critical target error, dev sda, sector 65535 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[   29.418022] sd 0:0:0:0: [sda] tag#168 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[   29.419604] sd 0:0:0:0: [sda] tag#168 Sense Key : Illegal Request 
[current]
[   29.420826] sd 0:0:0:0: [sda] tag#168 Add. Sense: Invalid field in cdb
[   29.421978] sd 0:0:0:0: [sda] tag#168 CDB: Write same(16) 93 08 00
00 00 00 00 01 ff fe 00 00 ff ff 00 00
[   29.423591] critical target error, dev sda, sector 131070 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[   29.425301] sd 0:0:0:0: [sda] tag#169 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[   29.426856] sd 0:0:0:0: [sda] tag#169 Sense Key : Illegal Request 
[current]
[   29.428020] sd 0:0:0:0: [sda] tag#169 Add. Sense: Invalid field in cdb
[   29.429329] sd 0:0:0:0: [sda] tag#169 CDB: Write same(16) 93 08 00
00 00 00 00 02 ff fd 00 00 ff ff 00 00
[   29.431314] critical target error, dev sda, sector 196605 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[   29.433681] sd 0:0:0:0: [sda] tag#170 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[   29.435182] sd 0:0:0:0: [sda] tag#170 Sense Key : Illegal Request 
[current]
[   29.436328] sd 0:0:0:0: [sda] tag#170 Add. Sense: Invalid field in cdb
[   29.437372] sd 0:0:0:0: [sda] tag#170 CDB: Write same(16) 93 08 00
00 00 00 00 03 ff fc 00 00 ff ff 00 00
[   29.438895] critical target error, dev sda, sector 262140 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[   29.440572] sd 0:0:0:0: [sda] tag#171 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[   29.442080] sd 0:0:0:0: [sda] tag#171 Sense Key : Illegal Request 
[current]
[   29.443277] sd 0:0:0:0: [sda] tag#171 Add. Sense: Invalid field in cdb
[   29.444353] sd 0:0:0:0: [sda] tag#171 CDB: Write same(16) 93 08 00
00 00 00 00 04 ff fb 00 00 ff ff 00 00
[   29.445919] critical target error, dev sda, sector 327675 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[   29.447607] sd 0:0:0:0: [sda] tag#172 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[   29.449145] sd 0:0:0:0: [sda] tag#172 Sense Key : Illegal Request 
[current]
[   29.450327] sd 0:0:0:0: [sda] tag#172 Add. Sense: Invalid field in cdb
[   29.451447] sd 0:0:0:0: [sda] tag#172 CDB: Write same(16) 93 08 00
00 00 00 00 05 ff fa 00 00 ff ff 00 00
[   29.452995] critical target error, dev sda, sector 393210 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[   29.454712] sd 0:0:0:0: [sda] tag#173 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[   29.456199] sd 0:0:0:0: [sda] tag#173 Sense Key : Illegal Request 
[current]
[   29.457409] sd 0:0:0:0: [sda] tag#173 Add. Sense: Invalid field in cdb
[   29.458486] sd 0:0:0:0: [sda] tag#173 CDB: Write same(16) 93 08 00
00 00 00 00 06 ff f9 00 00 ff ff 00 00
[   29.459836] critical target error, dev sda, sector 458745 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[   29.461266] sd 0:0:0:0: [sda] tag#174 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[   29.462608] sd 0:0:0:0: [sda] tag#174 Sense Key : Illegal Request 
[current]
[   29.463791] sd 0:0:0:0: [sda] tag#174 Add. Sense: Invalid field in cdb
[   29.464854] sd 0:0:0:0: [sda] tag#174 CDB: Write same(16) 93 08 00
00 00 00 00 07 ff f8 00 00 ff ff 00 00
[   29.466695] critical target error, dev sda, sector 524280 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[   29.468364] sd 0:0:0:0: [sda] tag#175 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[   29.469774] sd 0:0:0:0: [sda] tag#175 Sense Key : Illegal Request 
[current]
[   29.470890] sd 0:0:0:0: [sda] tag#175 Add. Sense: Invalid field in cdb
[   29.471867] sd 0:0:0:0: [sda] tag#175 CDB: Write same(16) 93 08 00
00 00 00 00 08 ff f7 00 00 ff ff 00 00
[   29.473323] critical target error, dev sda, sector 589815 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
#
#