linux-kernel - Re: [REGRESSION] critical target error, bisected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1plq8otwh.fsf@ca-mkp.ca.oracle.com>
Date: Fri, 16 Aug 2024 20:51:36 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@....com>
Cc: "Martin K. Petersen" <martin.petersen@...cle.com>,
        Chris Bainbridge
 <chris.bainbridge@...il.com>,
        "fengli@...rtx.com" <fengli@...rtx.com>, hch <hch@....de>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [REGRESSION] critical target error, bisected


Shinichiro,

> I guess SD_LBP_FULL would be more appropriate than SD_LBP_DISABLE,
> because the comment in drivers/scsi/sd.h says that SD_LBP_DISABLE
> indicates that "Discard disabled due to failed cmd".

> I confirmed that the fix patch avoids my failure both with
> SD_LBP_DISABLE and SD_LBP_FULL.

Yes, you are right. It is more appropriate to print "full" in sysfs when
LBMPE is disabled. Printing aside, the two modes are identical. I
switched the return to SDP_LBP_FULL.

-- 
Martin K. Petersen	Oracle Linux Engineering