linux-kernel - Re: [PATCH v4 02/12] kconfig: Add picosat.c (1/3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240816102001.21668-1-ole0811sch@gmail.com>
Date: Fri, 16 Aug 2024 12:20:01 +0200
From: Ole Schuerks <ole0811sch@...il.com>
To: masahiroy@...nel.org
Cc: deltaone@...ian.org,
	jan.sollmann@....de,
	jude.gyimah@....de,
	linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mcgrof@...nel.org,
	ole0811sch@...il.com,
	thorsten.berger@....de
Subject: Re: [PATCH v4 02/12] kconfig: Add picosat.c (1/3)

On 8/12/24 10:41, Masahiro Yamada wrote:
> On Wed, Jul 10, 2024 at 3:54 PM Ole Schuerks <ole0811sch@...il.com> wrote:
>>
>> PicoSAT is the SAT solver used in this project. picosat.c is the actual
>> SAT solver. Since the file is too big for a single patch, it needs to be
>> split up. This patch contains the first part of the file.
>>
>> Signed-off-by: Patrick Franz <deltaone@...ian.org>
>> Signed-off-by: Ibrahim Fayaz <phayax@...il.com>
>> Signed-off-by: Thorsten Berger <thorsten.berger@....de>
>> Signed-off-by: Ole Schuerks <ole0811sch@...il.com>
>> ---
>>  scripts/kconfig/picosat.c | 3000 +++++++++++++++++++++++++++++++++++++
>>  1 file changed, 3000 insertions(+)
>>  create mode 100644 scripts/kconfig/picosat.c
>
>
> I usually tend to avoid adding huge files like this.
>
>
> Is this for avoiding any portability issues across distributions?
>
>
>
> Debian:
> https://packages.debian.org/search?keywords=picosat
>
>
> Fedora:
> https://packages.fedoraproject.org/pkgs/picosat/picosat/
>

Thank you for the feedback. If we didn't respond to any feedback
take that as that an acknowledgement and that we'll implement the changes 
in v5.

I think that with these packages (and if we additionally provide a 
repository with a script to compile and install PicoSAT as a library for 
the other distros) this should be portable enough. We will remove the 
PicoSAT files in v5.

I assume that it should still be possible to use xconfig without PicoSAT 
though. What's the best way of letting the user know that they need to 
install PicoSAT if they want to use the conflict resolver? My idea would 
be to notify the user via the GUI when they try to use the interface of 
the conflict resolver without having PicoSAT installed. Do you see any 
issues with that/do you prefer some alternative approach?