linux-kernel - Re: [PATCH v4 07/12] kconfig: Add files for handling expressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240816102319.21739-1-ole0811sch@gmail.com>
Date: Fri, 16 Aug 2024 12:23:19 +0200
From: Ole Schuerks <ole0811sch@...il.com>
To: masahiroy@...nel.org
Cc: deltaone@...ian.org,
	jan.sollmann@....de,
	jude.gyimah@....de,
	linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mcgrof@...nel.org,
	ole0811sch@...il.com,
	thorsten.berger@....de
Subject: Re: [PATCH v4 07/12] kconfig: Add files for handling expressions

On 8/12/24 10:46, Masahiro Yamada wrote:
> On Wed, Jul 10, 2024 at 3:54 PM Ole Schuerks <ole0811sch@...il.com> wrote:
>>
>> To translate the Kconfig-model into propositional logic and resolve
>> conflicts, we need to handle propostional formulas.
>> These files contain many functions and macros to deal with
>> propositional formulas.
>>
>> Co-developed-by: Patrick Franz <deltaone@...ian.org>
>> Signed-off-by: Patrick Franz <deltaone@...ian.org>
>> Co-developed-by: Ibrahim Fayaz <phayax@...il.com>
>> Signed-off-by: Ibrahim Fayaz <phayax@...il.com>
>> Reviewed-by: Luis Chamberlain <mcgrof@...nel.org>
>> Tested-by: Evgeny Groshev <eugene.groshev@...il.com>
>> Suggested-by: Sarah Nadi <nadi@...berta.ca>
>> Suggested-by: Thorsten Berger <thorsten.berger@....de>
>> Signed-off-by: Thorsten Berger <thorsten.berger@....de>
>> Signed-off-by: Ole Schuerks <ole0811sch@...il.com>
>> ---
>>  scripts/kconfig/cf_expr.c | 2594 +++++++++++++++++++++++++++++++++++++
>>  scripts/kconfig/cf_expr.h |  296 +++++
>>  2 files changed, 2890 insertions(+)
>>  create mode 100644 scripts/kconfig/cf_expr.c
>>  create mode 100644 scripts/kconfig/cf_expr.h

>> +/*
>> + * convert a fexpr to a pexpr
>> + */
>> +struct pexpr *pexf(struct fexpr *fe)
>
>
>
>
> Not only this one, but more descriptive function name please.
>
> "pexf", so what?
> I do not understand what it is doing from the name.
>
>

Could you give us one or two examples of what other functions have bad 
names? I didn't find anything as bad as pexf() so I'm not sure what the 
expectations are. Thank you, that would be helpful.