[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <90939451-4e26-4aec-bf69-d078d88fb5c2@stanley.mountain>
Date: Fri, 16 Aug 2024 16:09:03 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Changhuang Liang <changhuang.liang@...rfivetech.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Jack Zhu <jack.zhu@...rfivetech.com>, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [v2] staging: media: starfive: Add the dynamic resolution support
On Fri, Aug 16, 2024 at 04:04:38PM +0300, Dan Carpenter wrote:
> On Fri, Aug 16, 2024 at 05:51:32AM -0700, Changhuang Liang wrote:
> > Add the dynamic resolution support for video "capture_raw" device.
> >
>
> What does this change look like from a use perspective if a user is reading the
> git log?
>
> > Fixes: e080f339c80a ("media: staging: media: starfive: camss: Add capture driver")
> >
>
> This looks like a new feature and not a bugfix. Please describe the bug more
> clearly if it's really a bugfix.
>
Actually the first version of the commit had a good description. Just go back
to that.
> Add multiple resolution support for video "capture_raw" device. Otherwise
> it will capture the wrong image data if the width is not 1920.
Btw:
1) Don't put a blank line after the Fixes tag.
2) Put a note under the --- cut off line that says what changed.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Please send v3.
regards,
dan carpenter
Powered by blists - more mailing lists