linux-kernel - Re: [v2] staging: media: starfive: Add the dynamic resolution support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240819132720.538468-1-changhuang.liang@starfivetech.com>
Date: Mon, 19 Aug 2024 06:27:20 -0700
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: dan.carpenter@...aro.org
Cc: changhuang.liang@...rfivetech.com,
	gregkh@...uxfoundation.org,
	hverkuil-cisco@...all.nl,
	jack.zhu@...rfivetech.com,
	laurent.pinchart@...asonboard.com,
	linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org,
	linux-staging@...ts.linux.dev,
	mchehab@...nel.org
Subject: Re: [v2] staging: media: starfive: Add the dynamic resolution support

Hi, Dan

Thanks for your comments.

>On Fri, Aug 16, 2024 at 04:04:38PM +0300, Dan Carpenter wrote:
>> On Fri, Aug 16, 2024 at 05:51:32AM -0700, Changhuang Liang wrote:
>> > Add the dynamic resolution support for video "capture_raw" device.
>> >
>>
>> What does this change look like from a use perspective if a user is reading the
>> git log?
>>
>> > Fixes: e080f339c80a ("media: staging: media: starfive: camss: Add capture driver")
>> >
>>
>> This looks like a new feature and not a bugfix.  Please describe the bug more
>> clearly if it's really a bugfix.
>>
>
>Actually the first version of the commit had a good description.  Just go back
>to that.
>

Yes, I forgot to synchronous description.

>> Add multiple resolution support for video "capture_raw" device. Otherwise
>> it will capture the wrong image data if the width is not 1920.
>
>Btw:
>1) Don't put a blank line after the Fixes tag.
>2) Put a note under the --- cut off line that says what changed.
>
>https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
>

Thanks for this.

>Please send v3.

regards,
Changhuang