linux-kernel - Re: [PATCH 12/13] media: qcom: camss: Add CSID Gen3 support for sm8550

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26504f16-2633-4607-92e5-d01363b85d57@quicinc.com>
Date: Fri, 16 Aug 2024 21:11:58 +0800
From: Depeng Shao <quic_depengs@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...cinc.com>, Yongsheng Li <quic_yon@...cinc.com>
Subject: Re: [PATCH 12/13] media: qcom: camss: Add CSID Gen3 support for
 sm8550

Hi Bryan,

On 8/16/2024 7:34 PM, Bryan O'Donoghue wrote:
> 
> Just noticed this too.
> 
> You're configuring the CSID routing here for each enabled VC but, you 
> should only do that once @ the top level
> 
> ->
> 
> 
>      __csid_configure_top(csid);
> 
>      /* Loop through all enabled VCs and configure stream for each */
>      for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS; i++)
>          if (csid->phy.en_vc & BIT(i)) {
>              __csid_configure_rdi_stream(csid, enable, i);
>              __csid_configure_rx(csid, &csid->phy, i);
>              __csid_ctrl_rdi(csid, enable, i);
>          }
> 

Yes, you are right, will move configure_top out of the for loop.

Thanks,
Depeng