linux-kernel - Re: [PATCH] ratelimit: convert flags to int to save 8 bytes in size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <w65wgoyfu65xzeftqcc2xyrikvrq2nfmmqiq3z5jqytt65g3wu@2kykf4kwra3z>
Date: Sat, 17 Aug 2024 14:41:52 +0200
From: Mateusz Guzik <mjguzik@...il.com>
To: akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] ratelimit: convert flags to int to save 8 bytes in size

On Sat, Aug 17, 2024 at 02:37:54PM +0200, Mateusz Guzik wrote:
> Only bit 1 is used, making an unsigned long a total overkill.
> 
> This brings it from 64 to 32 bytes, which in turn shrinks user_struct

sigh, 40 to 32 bytes of course

this is embedded into user_struct, avoidably pushing it past 128 bytes
of size

> from 136 to 128 bytes. Since the latter is allocated with hwalign, this
> means the total usage goes down from 192 to 128 bytes per object.
> 
> No functional changes.
> 
> Signed-off-by: Mateusz Guzik <mjguzik@...il.com>
> ---
> 
> ./scripts/get_maintainer.pl --git was most unhelpful showing nothing
> 
> I have no idea who to prod about it, I think it is pretty trivial not
> needing any discussion.
> 
> Andrew Morton pulled in some of the changes to the file, so that's my
> primary recipient.
> 
>  include/linux/ratelimit_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/ratelimit_types.h b/include/linux/ratelimit_types.h
> index 002266693e50..765232ce0b5e 100644
> --- a/include/linux/ratelimit_types.h
> +++ b/include/linux/ratelimit_types.h
> @@ -19,8 +19,8 @@ struct ratelimit_state {
>  	int		burst;
>  	int		printed;
>  	int		missed;
> +	unsigned int	flags;
>  	unsigned long	begin;
> -	unsigned long	flags;
>  };
>  
>  #define RATELIMIT_STATE_INIT_FLAGS(name, interval_init, burst_init, flags_init) { \
> -- 
> 2.43.0
> 
>