| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20240817124140.800637-2-erezgeva@nwtime.org>
Date: Sat, 17 Aug 2024 14:41:37 +0200
From: Erez Geva <erezgeva@...ime.org>
To: linux-mtd@...ts.infradead.org,
Tudor Ambarus <tudor.ambarus@...aro.org>,
Pratyush Yadav <pratyush@...nel.org>,
Michael Walle <mwalle@...nel.org>
Cc: linux-kernel@...r.kernel.org,
Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
devicetree@...r.kernel.org,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Erez Geva <ErezGeva2@...il.com>
Subject: [PATCH v3 1/4] mtd: spi-nor: core: add manufacturer flags
From: Erez Geva <ErezGeva2@...il.com>
Add flag for always trying reading SFDP:
Some vendors reuse all JEDEC IDs on manufacture table
with new chips that support SFDP.
Add flag for reading OTP parameters from device tree.
Some vendors reuse JEDEC IDs
with several chips with different OTP parameters.
Alternatively we read parameters from SFDP.
But the OTP parameters are absent from the SFDP.
So there is not other way but to add the OTP parameters in the device tree.
In this series, we will use the flags with Macronix.
Signed-off-by: Erez Geva <ErezGeva2@...il.com>
---
drivers/mtd/spi-nor/core.c | 36 ++++++++++++++++++++++++++++++-----
drivers/mtd/spi-nor/core.h | 7 ++++++-
drivers/mtd/spi-nor/otp.c | 6 +++---
drivers/mtd/spi-nor/winbond.c | 2 +-
4 files changed, 41 insertions(+), 10 deletions(-)
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index e0c4efc424f4..af522c426ac9 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -2891,10 +2891,11 @@ static void spi_nor_init_params_deprecated(struct spi_nor *nor)
spi_nor_manufacturer_init_params(nor);
- if (nor->info->no_sfdp_flags & (SPI_NOR_DUAL_READ |
- SPI_NOR_QUAD_READ |
- SPI_NOR_OCTAL_READ |
- SPI_NOR_OCTAL_DTR_READ))
+ if ((nor->info->no_sfdp_flags & (SPI_NOR_DUAL_READ |
+ SPI_NOR_QUAD_READ |
+ SPI_NOR_OCTAL_READ |
+ SPI_NOR_OCTAL_DTR_READ)) ||
+ nor->manufacturer->flags & SPI_NOR_MANUFACT_TTY_SFDP)
spi_nor_sfdp_init_params_deprecated(nor);
}
@@ -2911,7 +2912,32 @@ static void spi_nor_init_default_params(struct spi_nor *nor)
struct device_node *np = spi_nor_get_flash_node(nor);
params->quad_enable = spi_nor_sr2_bit1_quad_enable;
- params->otp.org = info->otp;
+ memset(¶ms->otp.org, 0, sizeof(struct spi_nor_otp_organization));
+ if (info->otp) {
+ memcpy(¶ms->otp.org, info->otp, sizeof(struct spi_nor_otp_organization));
+ } else if (nor->manufacturer->flags & SPI_NOR_MANUFACT_DT_OTP) {
+ /* Check for OTP information on device tree */
+ u32 n_regions, len;
+
+ if (!of_property_read_u32(np, "opt_n_regions", &n_regions) &&
+ n_regions > 0 &&
+ !of_property_read_u32(np, "otp_len", &len) &&
+ len > 0) {
+ u32 base, offset = 0;
+
+ if (n_regions > 1) {
+ /* If offset is not defined use length as offset */
+ if (of_property_read_u32(np, "otp_offset", &offset))
+ offset = len;
+ }
+ if (of_property_read_u32(np, "otp_base", &base))
+ base = 0;
+ params->otp.org.n_regions = n_regions;
+ params->otp.org.offset = offset;
+ params->otp.org.base = base;
+ params->otp.org.len = len;
+ }
+ }
/* Default to 16-bit Write Status (01h) Command */
nor->flags |= SNOR_F_HAS_16BIT_SR;
diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h
index 1516b6d0dc37..237196b908dd 100644
--- a/drivers/mtd/spi-nor/core.h
+++ b/drivers/mtd/spi-nor/core.h
@@ -326,7 +326,7 @@ struct spi_nor_otp_ops {
* @ops: OTP access ops
*/
struct spi_nor_otp {
- const struct spi_nor_otp_organization *org;
+ struct spi_nor_otp_organization org;
const struct spi_nor_otp_ops *ops;
};
@@ -560,12 +560,17 @@ struct flash_info {
* @parts: array of parts supported by this manufacturer
* @nparts: number of entries in the parts array
* @fixups: hooks called at various points in time during spi_nor_scan()
+ * @flags: manufacturer flags
*/
struct spi_nor_manufacturer {
const char *name;
const struct flash_info *parts;
unsigned int nparts;
const struct spi_nor_fixups *fixups;
+
+ u8 flags;
+#define SPI_NOR_MANUFACT_TTY_SFDP BIT(0)
+#define SPI_NOR_MANUFACT_DT_OTP BIT(0)
};
/**
diff --git a/drivers/mtd/spi-nor/otp.c b/drivers/mtd/spi-nor/otp.c
index 9a729aa3452d..ffb7ffeb9030 100644
--- a/drivers/mtd/spi-nor/otp.c
+++ b/drivers/mtd/spi-nor/otp.c
@@ -11,8 +11,8 @@
#include "core.h"
-#define spi_nor_otp_region_len(nor) ((nor)->params->otp.org->len)
-#define spi_nor_otp_n_regions(nor) ((nor)->params->otp.org->n_regions)
+#define spi_nor_otp_region_len(nor) ((nor)->params->otp.org.len)
+#define spi_nor_otp_n_regions(nor) ((nor)->params->otp.org.n_regions)
/**
* spi_nor_otp_read_secr() - read security register
@@ -222,7 +222,7 @@ int spi_nor_otp_is_locked_sr2(struct spi_nor *nor, unsigned int region)
static loff_t spi_nor_otp_region_start(const struct spi_nor *nor, unsigned int region)
{
- const struct spi_nor_otp_organization *org = nor->params->otp.org;
+ const struct spi_nor_otp_organization *org = &nor->params->otp.org;
return org->base + region * org->offset;
}
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index e065e4fd42a3..15af62aacc9a 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -307,7 +307,7 @@ static int winbond_nor_late_init(struct spi_nor *nor)
{
struct spi_nor_flash_parameter *params = nor->params;
- if (params->otp.org)
+ if (params->otp.org.n_regions)
params->otp.ops = &winbond_nor_otp_ops;
/*
--
2.39.2
Powered by blists - more mailing lists