linux-kernel - [PATCH] scsi: make minimum cdb size 6 for group codes 6 and 7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <CH3PR10MB7762FE48ED542A0BF7C1B59BFF822@CH3PR10MB7762.namprd10.prod.outlook.com>
Date: Fri, 16 Aug 2024 20:55:28 -0700
From: Txanton Bejos <txb2@...e.com>
To: James.Bottomley@...senPartnership.com,
	martin.petersen@...cle.com
Cc: linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Txanton Bejos <txb2@...e.com>
Subject: [PATCH] scsi: make minimum cdb size 6 for group codes 6 and 7

In Linux 0.99.12, a table of the command size for different CDB group
codes was added with a value of 10 for groups 6 and 7. In the SCSI
specification it is specified that for groups 6 and 7, the length of
the CDB is vendor-specific.

This fixes an issue when sending a CDB of size 6 with a group code of 6
or 7, where libata will respond with DID_ERROR instead of sending the
command because the length is below the value of 10 found in this table.

Signed-off-by: Txanton Bejos <txb2@...e.com>
---
 drivers/scsi/scsi_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_common.c b/drivers/scsi/scsi_common.c
index 04749fde1636..b482c8732f75 100644
--- a/drivers/scsi/scsi_common.c
+++ b/drivers/scsi/scsi_common.c
@@ -17,7 +17,7 @@ MODULE_LICENSE("GPL v2");
 
 /* Command group 3 is reserved and should never be used.  */
 const unsigned char scsi_command_size_tbl[8] = {
-	6, 10, 10, 12, 16, 12, 10, 10
+	6, 10, 10, 12, 16, 12, 6, 6
 };
 EXPORT_SYMBOL(scsi_command_size_tbl);
 

base-commit: 5f36bd89a9948ae23571f9ffd122d7de1ced73e0
-- 
2.46.0