linux-kernel - Re: [PATCH] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa331200-205e-4b00-ae02-343c96c52ae8@web.de>
Date: Sun, 18 Aug 2024 15:12:55 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Stuart Hayhurst <stuart.a.hayhurst@...il.com>, linux-input@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Benjamin Tissoires <bentiss@...nel.org>, Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH] HID: corsair-void: Add Corsair Void headset family driver

How do you think about to distinguish properties any further for available
device attributes?
https://elixir.bootlin.com/linux/v6.11-rc3/source/Documentation/driver-api/driver-model/device.rst#L38

…
> +++ b/drivers/hid/hid-corsair-void.c
> @@ -0,0 +1,851 @@
…
> +static DEVICE_ATTR(fw_version_receiver, 0444, corsair_void_report_firmware, NULL);
> +static DEVICE_ATTR(fw_version_headset, 0444, corsair_void_report_firmware, NULL);

* Are these really changeable?

* Can the macro “DEVICE_ATTR_RO” be applied?

…
> +MODULE_AUTHOR("Stuart Hayhurst");

Would you like to add an email address here?

Regards,
Markus