linux-kernel - Re: [PATCH] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALTg27kAMd-0tQdJ+k4Ur9i=kZ0qY_vffhm3ZT+_CX6tD_874Q@mail.gmail.com>
Date: Mon, 19 Aug 2024 00:17:06 +0100
From: Stuart <stuart.a.hayhurst@...il.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
	Benjamin Tissoires <bentiss@...nel.org>, Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH] HID: corsair-void: Add Corsair Void headset family driver

> How do you think about to distinguish properties any further for available
> device attributes?
> https://elixir.bootlin.com/linux/v6.11-rc3/source/Documentation/driver-api/driver-model/device.rst#L38

Sorry I'm not sure I follow you're saying

> * Are these really changeable?

The receiver firmware version wouldn't change during the device's
lifetime unless someone wrote a firmware updater for Linux, even then
it would probably reconnect
The headset firmware version could theoretically change if you changed
which headset is paired, but I don't have 2 headsets of the same model
to test this

> * Can the macro “DEVICE_ATTR_RO” be applied?

Done, also applied DEVICE_ATTR_WO

> > +MODULE_AUTHOR("Stuart Hayhurst");
> Would you like to add an email address here?

Done. Thanks again for the review, I'll submit a v2 with the changes so far.

Stuart

On Sun, Aug 18, 2024 at 2:12 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> How do you think about to distinguish properties any further for available
> device attributes?
> https://elixir.bootlin.com/linux/v6.11-rc3/source/Documentation/driver-api/driver-model/device.rst#L38
>
>
> …
> > +++ b/drivers/hid/hid-corsair-void.c
> > @@ -0,0 +1,851 @@
> …
> > +static DEVICE_ATTR(fw_version_receiver, 0444, corsair_void_report_firmware, NULL);
> > +static DEVICE_ATTR(fw_version_headset, 0444, corsair_void_report_firmware, NULL);
>
> * Are these really changeable?
>
> * Can the macro “DEVICE_ATTR_RO” be applied?
>
>
> …
> > +MODULE_AUTHOR("Stuart Hayhurst");
>
> Would you like to add an email address here?
>
> Regards,
> Markus