linux-kernel - Re: [PATCH v2 06/14] KEYS: PGP data parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58a857afc8b97433ab0056628958d81e69bd7421.camel@huaweicloud.com>
Date: Mon, 19 Aug 2024 16:38:08 +0200
From: Roberto Sassu <roberto.sassu@...weicloud.com>
To: Jeff Johnson <quic_jjohnson@...cinc.com>, dhowells@...hat.com, 
	dwmw2@...radead.org, herbert@...dor.apana.org.au, davem@...emloft.net
Cc: linux-kernel@...r.kernel.org, keyrings@...r.kernel.org, 
	linux-crypto@...r.kernel.org, zohar@...ux.ibm.com, 
	linux-integrity@...r.kernel.org, Roberto Sassu <roberto.sassu@...wei.com>
Subject: Re: [PATCH v2 06/14] KEYS: PGP data parser

On Mon, 2024-08-19 at 07:36 -0700, Jeff Johnson wrote:
> On 8/18/24 09:57, Roberto Sassu wrote:
> ...
> > diff --git a/crypto/asymmetric_keys/pgp_public_key.c b/crypto/asymmetric_keys/pgp_public_key.c
> > new file mode 100644
> > index 000000000000..cb399f5cdd3e
> > --- /dev/null
> > +++ b/crypto/asymmetric_keys/pgp_public_key.c
> > @@ -0,0 +1,366 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Instantiate a public key crypto key from PGP format data [RFC 4880]
> > + *
> > + * Copyright (C) 2011 Red Hat, Inc. All Rights Reserved.
> > + * Written by David Howells (dhowells@...hat.com)
> > + */
> > +
> > +#define pr_fmt(fmt) "PGP: "fmt
> > +#include <linux/module.h>
> > +#include <linux/kernel.h>
> > +#include <linux/slab.h>
> > +#include <linux/mpi.h>
> > +#include <keys/asymmetric-subtype.h>
> > +#include <keys/asymmetric-parser.h>
> > +#include <crypto/hash.h>
> > +#include <crypto/public_key.h>
> > +
> > +#include "pgp_parser.h"
> > +
> > +#define MAX_MPI 5
> > +#define KEYCTL_SUPPORTS_ENCDEC \
> > +	(KEYCTL_SUPPORTS_ENCRYPT | KEYCTL_SUPPORTS_DECRYPT)
> > +#define KEYCTL_SUPPORTS_SIGVER (KEYCTL_SUPPORTS_SIGN | KEYCTL_SUPPORTS_VERIFY)
> > +
> > +MODULE_LICENSE("GPL");
> 
> Missing MODULE_DESCRIPTION()

Thanks! Will add it.

Roberto