linux-kernel - Re: [PATCH v2 04/14] PGPLIB: Basic packet parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fafa64ff-63ee-4af1-b669-939dc1933012@quicinc.com>
Date: Mon, 19 Aug 2024 07:34:40 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Roberto Sassu <roberto.sassu@...weicloud.com>, <dhowells@...hat.com>,
        <dwmw2@...radead.org>, <herbert@...dor.apana.org.au>,
        <davem@...emloft.net>
CC: <linux-kernel@...r.kernel.org>, <keyrings@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>, <zohar@...ux.ibm.com>,
        <linux-integrity@...r.kernel.org>,
        Roberto Sassu <roberto.sassu@...wei.com>
Subject: Re: [PATCH v2 04/14] PGPLIB: Basic packet parser

On 8/18/24 09:57, Roberto Sassu wrote:
...
> diff --git a/crypto/asymmetric_keys/pgp_library.c b/crypto/asymmetric_keys/pgp_library.c
> new file mode 100644
> index 000000000000..33ed01f67654
> --- /dev/null
> +++ b/crypto/asymmetric_keys/pgp_library.c
> @@ -0,0 +1,272 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* PGP packet parser (RFC 4880)
> + *
> + * Copyright (C) 2011 Red Hat, Inc. All Rights Reserved.
> + * Written by David Howells (dhowells@...hat.com)
> + */
> +
> +#define pr_fmt(fmt) "PGPL: "fmt
> +#include <linux/errno.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +
> +#include "pgplib.h"
> +
> +MODULE_LICENSE("GPL");

Missing MODULE_DESCRIPTION()

Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning when built with make W=1. Recently, multiple
developers have been eradicating these warnings treewide, and very few
are left, so please don't introduce a new one :)

/jeff