linux-kernel - Re: [PATCH] scsi: elx: libefc: potential use after free in efc_nport_vport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11af2cbb-9474-477b-9067-aeb551ac382a@flourine.local>
Date: Mon, 19 Aug 2024 08:57:32 +0200
From: Daniel Wagner <dwagner@...e.de>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: James Smart <jsmart2021@...il.com>, 
	James Smart <james.smart@...adcom.com>, Ram Vegesna <ram.vegesna@...adcom.com>, 
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	linux-scsi@...r.kernel.org, target-devel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] scsi: elx: libefc: potential use after free in
 efc_nport_vport_del()

On Thu, Aug 15, 2024 at 02:29:05PM GMT, Dan Carpenter wrote:
> The kref_put() function will call nport->release if the refcount drops
> to zero.  The nport->release release function is _efc_nport_free() which
> frees "nport".  But then we dereference "nport" on the next line which
> is a use after free.  Re-order these lines to avoid the use after free.
> 
> Fixes: fcd427303eb9 ("scsi: elx: libefc: SLI and FC PORT state machine interfaces")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
> From static analysis.  Untested.  But it seems low risk.

Look reasonable.

Reviewed-by: Daniel Wagner <dwagner@...e.de>