linux-kernel - Re: [PATCH] scsi: elx: libefc: potential use after free in efc_nport_vport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1ttfckpul.fsf@ca-mkp.ca.oracle.com>
Date: Thu, 22 Aug 2024 21:08:58 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: James Smart <jsmart2021@...il.com>,
        James Smart
 <james.smart@...adcom.com>,
        Ram Vegesna <ram.vegesna@...adcom.com>,
        "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        "Martin
 K. Petersen" <martin.petersen@...cle.com>,
        Daniel Wagner
 <dwagner@...e.de>, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] scsi: elx: libefc: potential use after free in
 efc_nport_vport_del()


Dan,

> The kref_put() function will call nport->release if the refcount drops
> to zero. The nport->release release function is _efc_nport_free()
> which frees "nport". But then we dereference "nport" on the next line
> which is a use after free. Re-order these lines to avoid the use after
> free.

Applied to 6.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering