linux-kernel - Re: [PATCH -next] spi: bcm63xx: Fix module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOiHx=kutdcmATMQNsp+aYvAm7g2u+GDRfdg6Oe1fcE7XNRbTA@mail.gmail.com>
Date: Mon, 19 Aug 2024 09:47:24 +0200
From: Jonas Gorski <jonas.gorski@...il.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: broonie@...nel.org, linux-spi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] spi: bcm63xx: Fix module autoloading

Hi,

On Mon, 19 Aug 2024 at 05:59, Jinjie Ruan <ruanjinjie@...wei.com> wrote:
>
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.

Your code change adds a MODULE_DEVICE_TABLE() to platform_device_id,
not of_device_id (which is also missing it). Please align change and
message.

Also since this is a fix, please add an appropriate Fixes tag and Cc stable.

>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>

Apart from that the change looks good.

Reviewed-by: Jonas Gorski <jonas.gorski@...il.com>

Best Regards,
Jonas