linux-kernel - Re: [PATCH -next] spi: bcm63xx: Fix module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb368941-b9a1-f673-85e0-b98bd947e0c3@huawei.com>
Date: Mon, 19 Aug 2024 16:07:58 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: Jonas Gorski <jonas.gorski@...il.com>
CC: <broonie@...nel.org>, <linux-spi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] spi: bcm63xx: Fix module autoloading



On 2024/8/19 15:47, Jonas Gorski wrote:
> Hi,
> 
> On Mon, 19 Aug 2024 at 05:59, Jinjie Ruan <ruanjinjie@...wei.com> wrote:
>>
>> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
>> based on the alias from of_device_id table.
> 
> Your code change adds a MODULE_DEVICE_TABLE() to platform_device_id,
> not of_device_id (which is also missing it). Please align change and
> message.
> 
> Also since this is a fix, please add an appropriate Fixes tag and Cc stable.
> 
>>
>> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> 
> Apart from that the change looks good.
> 
> Reviewed-by: Jonas Gorski <jonas.gorski@...il.com>

Jonas, Thank you, I'll fix it, thank you!

> 
> Best Regards,
> Jonas