linux-kernel - Re: [PATCH 03/12] drm/edid: constify argument of drm_edid_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877ccc7wji.fsf@intel.com>
Date: Mon, 19 Aug 2024 11:21:21 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Thomas Weißschuh <linux@...ssschuh.net>, Harry Wentland
 <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, Rodrigo Siqueira
 <Rodrigo.Siqueira@....com>, Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>, Xinhui Pan
 <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>, Daniel Vetter
 <daniel@...ll.ch>, jinzh <jinzh@...hub.amd.com>, Aric Cyr
 <Aric.Cyr@....com>, Alan Liu <HaoPing.Liu@....com>, Tony Cheng
 <Tony.Cheng@....com>, Andrey Grodzovsky <Andrey.Grodzovsky@....com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, Harry Wentland <Harry.Wentland@....com>,
 Thomas Weißschuh <linux@...ssschuh.net>
Subject: Re: [PATCH 03/12] drm/edid: constify argument of drm_edid_is_valid()

On Sun, 18 Aug 2024, Thomas Weißschuh <linux@...ssschuh.net> wrote:
> drm_edid_is_valid() does not modify its argument, so mark it as const.

That's not true.

BR,
Jani.

>
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
>  drivers/gpu/drm/drm_edid.c | 2 +-
>  include/drm/drm_edid.h     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index f68a41eeb1fa..69fb11741abd 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -2034,7 +2034,7 @@ EXPORT_SYMBOL(drm_edid_block_valid);
>   *
>   * Return: True if the EDID data is valid, false otherwise.
>   */
> -bool drm_edid_is_valid(struct edid *edid)
> +bool drm_edid_is_valid(const struct edid *edid)
>  {
>  	int i;
>  
> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
> index 6bdfa254a1c1..a5b377c4a342 100644
> --- a/include/drm/drm_edid.h
> +++ b/include/drm/drm_edid.h
> @@ -442,7 +442,7 @@ int drm_add_modes_noedid(struct drm_connector *connector,
>  int drm_edid_header_is_valid(const void *edid);
>  bool drm_edid_block_valid(u8 *raw_edid, int block, bool print_bad_edid,
>  			  bool *edid_corrupt);
> -bool drm_edid_is_valid(struct edid *edid);
> +bool drm_edid_is_valid(const struct edid *edid);
>  void drm_edid_get_monitor_name(const struct edid *edid, char *name,
>  			       int buflen);
>  struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev,

-- 
Jani Nikula, Intel