linux-kernel - Re: [PATCH v1] pwm: lpss: wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsMAn3hQ4yDq-Gg6@smile.fi.intel.com>
Date: Mon, 19 Aug 2024 11:21:51 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Raag Jadav <raag.jadav@...el.com>
Cc: ukleinek@...nel.org, mika.westerberg@...ux.intel.com,
	jarkko.nikula@...ux.intel.com, linux-pwm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] pwm: lpss: wait_for_update() before configuring pwm

On Mon, Aug 19, 2024 at 01:34:12PM +0530, Raag Jadav wrote:
> Wait for SW_UPDATE bit to clear before configuring pwm channel instead of

PWM

> failing right away, which will reduce failure rates on early access.

So, what is the problem this patch solves (or is trying to solve)?
Second, there are two important behavioural changes:
- error code change (it's visible to user space);
- an additional, quite a long by the way, timeout.

Second one does worry me a lot as it might add these 0.5s to the boot time
or so per PWM in question.

-- 
With Best Regards,
Andy Shevchenko