linux-kernel - Re: [PATCH 07/14] Input: samsung-keypad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vizxklhqb2gvevfpup262s6dbmljlnit5oc2uxv2zubfuhcy73@3ev5tsopnhxg>
Date: Mon, 19 Aug 2024 14:57:20 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>, Mark Brown <broonie@...nel.org>, 
	linux-input@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH 07/14] Input: samsung-keypad - use per-chip parameters

On Sun, Aug 18, 2024 at 09:58:04PM -0700, Dmitry Torokhov wrote:
> Instead of doing conditional logic based on the chip type, define
> per-chip parameter structure, and reference it in the match data
> (either of_device_id or platform_device_id).
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  drivers/input/keyboard/samsung-keypad.c | 61 +++++++++++++++----------

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof