linux-kernel - Re: [PATCH v8 12/13] acpi/ghes: cleanup generic error data logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240819145734.03977654@imammedo.users.ipa.redhat.com>
Date: Mon, 19 Aug 2024 14:57:34 +0200
From: Igor Mammedov <imammedo@...hat.com>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Shiju Jose
 <shiju.jose@...wei.com>, "Michael S. Tsirkin" <mst@...hat.com>, Ani Sinha
 <anisinha@...hat.com>, Dongjiu Geng <gengdongjiu1@...il.com>,
 linux-kernel@...r.kernel.org, qemu-arm@...gnu.org, qemu-devel@...gnu.org
Subject: Re: [PATCH v8 12/13] acpi/ghes: cleanup generic error data logic

On Fri, 16 Aug 2024 09:37:44 +0200
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote:

> Remove comments that are obvious.
> 
> No functional changes.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
these comments help if you don't have spec side by side with code
to compare. I'd even say such comments are preferable than no comments
when composing an ACPI table.

pls, drop the patch

> ---
>  hw/acpi/ghes.c | 38 +++++++++++++++-----------------------
>  1 file changed, 15 insertions(+), 23 deletions(-)
> 
> diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
> index 4f7b6c5ad2b6..a822a5eafaa0 100644
> --- a/hw/acpi/ghes.c
> +++ b/hw/acpi/ghes.c
> @@ -130,34 +130,28 @@ static void build_ghes_hw_error_notification(GArray *table, const uint8_t type)
>   * ACPI 6.1: 18.3.2.7.1 Generic Error Data
>   */
>  static void acpi_ghes_generic_error_data(GArray *table,
> -                const uint8_t *section_type, uint32_t error_severity,
> -                uint8_t validation_bits, uint8_t flags,
> -                uint32_t error_data_length, QemuUUID fru_id,
> -                uint64_t time_stamp)
> +                                         const uint8_t *section_type,
> +                                         uint32_t error_severity,
> +                                         uint8_t validation_bits,
> +                                         uint8_t flags,
> +                                         uint32_t error_data_length,
> +                                         QemuUUID fru_id,
> +                                         uint64_t time_stamp)
>  {
>      const uint8_t fru_text[20] = {0};
>  
> -    /* Section Type */
>      g_array_append_vals(table, section_type, 16);
> -
> -    /* Error Severity */
>      build_append_int_noprefix(table, error_severity, 4);
> +
>      /* Revision */
>      build_append_int_noprefix(table, 0x300, 2);
> -    /* Validation Bits */
> +
>      build_append_int_noprefix(table, validation_bits, 1);
> -    /* Flags */
>      build_append_int_noprefix(table, flags, 1);
> -    /* Error Data Length */
>      build_append_int_noprefix(table, error_data_length, 4);
>  
> -    /* FRU Id */
>      g_array_append_vals(table, fru_id.data, ARRAY_SIZE(fru_id.data));
> -
> -    /* FRU Text */
>      g_array_append_vals(table, fru_text, sizeof(fru_text));
> -
> -    /* Timestamp */
>      build_append_int_noprefix(table, time_stamp, 8);
>  }
>  
> @@ -165,19 +159,17 @@ static void acpi_ghes_generic_error_data(GArray *table,
>   * Generic Error Status Block
>   * ACPI 6.1: 18.3.2.7.1 Generic Error Data
>   */
> -static void acpi_ghes_generic_error_status(GArray *table, uint32_t block_status,
> -                uint32_t raw_data_offset, uint32_t raw_data_length,
> -                uint32_t data_length, uint32_t error_severity)
> +static void acpi_ghes_generic_error_status(GArray *table,
> +                                           uint32_t block_status,
> +                                           uint32_t raw_data_offset,
> +                                           uint32_t raw_data_length,
> +                                           uint32_t data_length,
> +                                           uint32_t error_severity)
>  {
> -    /* Block Status */
>      build_append_int_noprefix(table, block_status, 4);
> -    /* Raw Data Offset */
>      build_append_int_noprefix(table, raw_data_offset, 4);
> -    /* Raw Data Length */
>      build_append_int_noprefix(table, raw_data_length, 4);
> -    /* Data Length */
>      build_append_int_noprefix(table, data_length, 4);
> -    /* Error Severity */
>      build_append_int_noprefix(table, error_severity, 4);
>  }
>