linux-kernel - Re: [PATCH 12/13] media: qcom: camss: Add CSID Gen3 support for sm8550

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6660e46e-14e5-4867-a1b2-d90660310b02@quicinc.com>
Date: Mon, 19 Aug 2024 21:18:40 +0800
From: Depeng Shao <quic_depengs@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...cinc.com>, Yongsheng Li <quic_yon@...cinc.com>
Subject: Re: [PATCH 12/13] media: qcom: camss: Add CSID Gen3 support for
 sm8550

Hi Bryan,

On 8/16/2024 10:45 PM, Bryan O'Donoghue wrote:
> On 12/08/2024 15:41, Depeng Shao wrote:
>> +    for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS; i++)
>> +        if (csid->phy.en_vc & BIT(i)) {
>> +            writel(BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + i),
>> +                        csid->base + CSID_BUF_DONE_IRQ_CLEAR);
>> +            writel(0x1 << IRQ_CMD_CLEAR, csid->base + CSID_IRQ_CMD);
> 
> IRQ_CMD_CLEAR is for the CSID block not per RDI.
> 

Sure, I will move IRQ_CMD_CLEAR outside of this loop.

> I think you need to move the write outside of this loop too.
> 
>> +            writel(BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + i),
>> +                        csid->base + CSID_BUF_DONE_IRQ_MASK);
>> +        }
> 

Yes, this also can be moved to outside of the loop. I will update them.

Thanks,
Depeng