linux-kernel - Re: [PATCH 12/13] media: qcom: camss: Add CSID Gen3 support for sm8550

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1633e348-5b81-4ca6-bdb1-04bd8f81c6b8@quicinc.com>
Date: Mon, 19 Aug 2024 21:23:24 +0800
From: Depeng Shao <quic_depengs@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...cinc.com>, Yongsheng Li <quic_yon@...cinc.com>
Subject: Re: [PATCH 12/13] media: qcom: camss: Add CSID Gen3 support for
 sm8550

Hi Bryan,

On 8/16/2024 10:21 PM, Bryan O'Donoghue wrote:
> On 12/08/2024 15:41, Depeng Shao wrote:
>> +#define CSID_RDI_CFG1(rdi)        (0x510 + 0x100 * (rdi))
>> +#define        RDI_CFG1_DROP_H_EN        5
>> +#define        RDI_CFG1_DROP_V_EN        6
>> +#define        RDI_CFG1_CROP_H_EN        7
>> +#define        RDI_CFG1_CROP_V_EN        8
>> +#define        RDI_CFG1_PIX_STORE        10
> 
> Hmm - is bit 10 valid ? I'm looking at a register set derived from 8550 
> and don't see it
> 

The bit10 is valid in sm8550, but it isn't there in sm8750.

>> +#define        RDI_CFG1_PACKING_FORMAT        15
> 
> Bit 15 selects either BIT(15) = 0 PACKING_FORMAT_PLAIN or BIT(15) = 1 
> PACKING_FORMAT_MIPI
> 
> Please give this bit a more descriptive name =>
> 
> #define        RDI_CFG1_PACKING_FORMAT_MIPI        15
> 

Sure. I will update it.

Thanks,
Depeng