linux-kernel - Re: [PATCH] ipmi:ssif: Exit early when there is a SMBus error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240820154220.qnbuqebretmz42wd@localhost.localdomain>
Date: Tue, 20 Aug 2024 18:42:20 +0300
From: "Ivan T. Ivanov" <iivanov@...e.de>
To: Corey Minyard <corey@...yard.net>
Cc: minyard@....org, openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi:ssif: Exit early when there is a SMBus error

Hi,

On 08-20 10:31, Corey Minyard wrote:
> > >
> > > >
> > > > 3) It appears the response to the GET_DEVICE_ID command, though a
> > > > response is returned, is not valid.  The right way to handle this would
> > > > be to do more validation in the ssif_detect() function.  It doesn't do
> > > > any validation of the response data, and that's really what needs to be
> > > > done.
> > > >
> > >
> > > do_cmd() in ssif_detect() already do validation. Perhaps,
> > > ssif_probe() should just not return ENODEV in case of error.
> > >
> >
> > Oh, I wanted to say ssif_detect, not ssif_probe.
> 
> Yeah, that's probably the right solution.  I'll look at this a bit.
> But I see the problem.  Do you want to do a patch, or do you want me
> to?

If you want to do it, please go ahead. I don't mind.

Thanks,
Ivan