linux-kernel - Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALTg27nNxjicXCGZMAqbebmUWraRqyqDm2hrTk5WZ=igJerX5g@mail.gmail.com>
Date: Tue, 20 Aug 2024 18:39:24 +0100
From: Stuart <stuart.a.hayhurst@...il.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
	Benjamin Tissoires <bentiss@...nel.org>, Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver

> Would you like to return the value directly (without an intermediate local variable)?
Done, thanks

Stuart

On Tue, Aug 20, 2024 at 10:17 AM Markus Elfring <Markus.Elfring@....de> wrote:
>
> …
> > +++ b/drivers/hid/hid-corsair-void.c
> > @@ -0,0 +1,842 @@
> …
> > +static int corsair_void_set_sidetone_wireless(struct device *dev, const char *buf,
> > +                                           unsigned char sidetone)
> > +{
> …
> > +     int ret = 0;
> …
> > +     ret = hid_hw_raw_request(hid_dev, CORSAIR_VOID_SIDETONE_REQUEST_ID,
> > +                              send_buf, 12, HID_FEATURE_REPORT,
> > +                              HID_REQ_SET_REPORT);
> > +
> > +     return ret;
> > +}
>
> Would you like to return the value directly (without an intermediate local variable)?
>
> Regards,
> Markus