linux-kernel - Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64039307-fcfc-4e08-8727-c805964f7386@web.de>
Date: Tue, 20 Aug 2024 11:16:51 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Stuart Hayhurst <stuart.a.hayhurst@...il.com>, linux-input@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Benjamin Tissoires <bentiss@...nel.org>, Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family
 driver

…
> +++ b/drivers/hid/hid-corsair-void.c
> @@ -0,0 +1,842 @@
…
> +static int corsair_void_set_sidetone_wireless(struct device *dev, const char *buf,
> +					      unsigned char sidetone)
> +{
…
> +	int ret = 0;
…
> +	ret = hid_hw_raw_request(hid_dev, CORSAIR_VOID_SIDETONE_REQUEST_ID,
> +				 send_buf, 12, HID_FEATURE_REPORT,
> +				 HID_REQ_SET_REPORT);
> +
> +	return ret;
> +}

Would you like to return the value directly (without an intermediate local variable)?

Regards,
Markus