linux-kernel - Re: [PATCH 1/1] scsi: ufs-mediatek: Add UFSHCD_QUIRK_BROKEN_LSDBS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9eaebd6bf66231ce3f1a450d120fb1a3188ad2a8.camel@mediatek.com>
Date: Tue, 20 Aug 2024 05:58:24 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "mary@...y.zone" <mary@...y.zone>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"chu.stanley@...il.com" <chu.stanley@...il.com>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH 1/1] scsi: ufs-mediatek: Add UFSHCD_QUIRK_BROKEN_LSDBS_CAP

On Mon, 2024-08-19 at 00:24 +0200, Mary Guillemard wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  MT8183 supports UFSHCI 2.1 spec, but report a bogus value of 1 in
> the
> reserved part for the Legacy Single Doorbell Support (LSDBS)
> capability.
> 
> This set UFSHCD_QUIRK_BROKEN_LSDBS_CAP when MCQ support is explicitly
> disabled, allowing the device to be properly registered.
> 
> Signed-off-by: Mary Guillemard <mary@...y.zone>
> ---
>  drivers/ufs/host/ufs-mediatek.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-
> mediatek.c
> index 02c9064284e1..9a5919434c4e 100644
> --- a/drivers/ufs/host/ufs-mediatek.c
> +++ b/drivers/ufs/host/ufs-mediatek.c
> @@ -1026,6 +1026,9 @@ static int ufs_mtk_init(struct ufs_hba *hba)
>  	if (host->caps & UFS_MTK_CAP_DISABLE_AH8)
>  		hba->caps |= UFSHCD_CAP_HIBERN8_WITH_CLK_GATING;
>  
> +	if (host->caps & UFS_MTK_CAP_DISABLE_MCQ)
> +		hba->quirks |= UFSHCD_QUIRK_BROKEN_LSDBS_CAP;
> +
>  	ufs_mtk_init_clocks(hba);
>  
>  	/*
> -- 
> 2.46.0


Reviewed-by: Peter Wang <peter.wang@...iatek.com>