linux-kernel - Re: [PATCH] mm/memcontrol: respect zswap.writeback setting from parent cg too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240819180131.27b0ea66dd50b83c85102540@linux-foundation.org>
Date: Mon, 19 Aug 2024 18:01:31 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Yosry Ahmed <yosryahmed@...gle.com>
Cc: Nhat Pham <nphamcs@...il.com>, Mike Yuan <me@...dnzj.com>,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org, cgroups@...r.kernel.org,
 Muchun Song <muchun.song@...ux.dev>, Shakeel Butt <shakeel.butt@...ux.dev>,
 Roman Gushchin <roman.gushchin@...ux.dev>, Michal Hocko
 <mhocko@...nel.org>, Johannes Weiner <hannes@...xchg.org>
Subject: Re: [PATCH] mm/memcontrol: respect zswap.writeback setting from
 parent cg too

On Mon, 19 Aug 2024 12:05:44 -0700 Yosry Ahmed <yosryahmed@...gle.com> wrote:

> > Ah yeah, I was thinking this could be done in a follow-up patch.
> >
> > But yes, please - documentation. Preferably everything together as v2.
> >
> > >
> > > Also, do we want a Fixes tag and to backport this so that current
> > > users get the new behavior ASAP?
> >
> > Hmm, I wonder if it's more confusing for users to change the behavior
> > in older kernels.
> >
> > (OTOH, if this already is what people expect, then yeah it's a good
> > idea to backport).
> 
> My rationale is that if people will inevitably get the behavior change
> when they upgrade their kernel, I'd rather they get it sooner rather
> than later, before more users start depending on the old behavior.
> 
> I am guessing there is a chance this is not what backports are meant
> for. Andrew, any thoughts on this?

I agree.  It does depend on how long the old behavior has been out in
the field, and on our assessment of how many people are likely to
inconvenienced.  So... yes please, what is that Fixes:?