linux-kernel - Re: [BUG] tracing: dynamic ftrace selftest detected failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240820100330.9ee6f3d51f22bb9bab7c4b83@kernel.org>
Date: Tue, 20 Aug 2024 10:03:30 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [BUG] tracing: dynamic ftrace selftest detected failures

On Mon, 19 Aug 2024 12:02:44 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 20 Aug 2024 00:56:49 +0900
> Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:
> > 
> > > 
> > > We may need to add "noinline" or something to make sure those functions
> > > don't get inlined for LTO.  
> > 
> > Yeah, we need such option at least for function call test.
> 
> Could you add the noinline, and if it fixes the issue send a patch?

I found the target function already has "noinline". I tried to add noinline
to the testing function (callsite), but it also did not work.
I think "noinline" is for the compiler, but LTO is done by the linker.

I found a discussion similar to this problem, but it seems very hacky.

https://groups.google.com/g/llvm-dev/c/6baI9LISmSU/m/uEeY_CRbBQAJ?pli=1

Thank you,

> 
> Thanks,
> 
> -- Steve
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>