[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240820075401.1206522-1-make24@iscas.ac.cn>
Date: Tue, 20 Aug 2024 15:54:01 +0800
From: Ma Ke <make24@...as.ac.cn>
To: maz@...nel.org,
tglx@...utronix.de,
Suravee.Suthikulpanit@....com,
akpm@...ux-foundation.org
Cc: linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org,
Ma Ke <make24@...as.ac.cn>,
stable@...r.kernel.org
Subject: [PATCH v2] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init
Add the missing of_node_put() to release the refcount incremented
by of_find_matching_node().
Cc: stable@...r.kernel.org
Fixes: 4266ab1a8ff5 ("irqchip/gic-v2m: Refactor to prepare for ACPI support")
Signed-off-by: Ma Ke <make24@...as.ac.cn>
---
Changes in v2:
- modified the patch according to suggestions.
---
drivers/irqchip/irq-gic-v2m.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index 51af63c046ed..d5988012eb40 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -407,12 +407,12 @@ static int __init gicv2m_of_init(struct fwnode_handle *parent_handle,
ret = gicv2m_init_one(&child->fwnode, spi_start, nr_spis,
&res, 0);
- if (ret) {
- of_node_put(child);
+ if (ret)
break;
- }
}
+ if (ret && child)
+ of_put_node(child);
if (!ret)
ret = gicv2m_allocate_domains(parent);
if (ret)
--
2.25.1
Powered by blists - more mailing lists