linux-kernel - Re: [PATCH v2] irqchip/gic-v2m: Fix refcount leak in gicv2m_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86v7zvy3vw.wl-maz@kernel.org>
Date: Tue, 20 Aug 2024 09:50:27 +0100
From: Marc Zyngier <maz@...nel.org>
To: Ma Ke <make24@...as.ac.cn>
Cc: tglx@...utronix.de,
	Suravee.Suthikulpanit@....com,
	akpm@...ux-foundation.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init

On Tue, 20 Aug 2024 08:54:01 +0100,
Ma Ke <make24@...as.ac.cn> wrote:
> 
> Add the missing of_node_put() to release the refcount incremented
> by of_find_matching_node().

This doesn't reflect the patch anymore. Something like this should be
closer to reality:

"We fail to perform an of_node_put() when of_address_to_resource()
fails, leading to a refcount leak.

Address this by moving the error handling path outside of the loop and
making it common to all failure modes."

With the commit message fixed:

Reviewed-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.