linux-kernel - Re: [PATCH] gpio: Simplify using devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MdN045+6LzxeWa9VwuzDDbVy7o0pESXc3hrCxrnatSSLw@mail.gmail.com>
Date: Tue, 20 Aug 2024 10:36:00 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Rong Qianfeng <rongqianfeng@...o.com>
Cc: Keerthy <j-keerthy@...com>, Linus Walleij <linus.walleij@...aro.org>, 
	Shubhrajyoti Datta <shubhrajyoti.datta@....com>, Srinivas Neeli <srinivas.neeli@....com>, 
	Michal Simek <michal.simek@....com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	opensource.kernel@...o.com
Subject: Re: [PATCH] gpio: Simplify using devm_clk_get_enabled()

On Tue, Aug 20, 2024 at 10:33 AM Rong Qianfeng <rongqianfeng@...o.com> wrote:
>
> devm_clk_get_enabled() will call devm_clk_get() + clk_prepare_enable()
> and the clock will automatically be disabled, unprepared and freed when
> the device is unbound from the bus. So simplify .probe() and .remove()
> accordingly.
>
> Signed-off-by: Rong Qianfeng <rongqianfeng@...o.com>
> ---
>  drivers/gpio/gpio-davinci.c  | 13 ++-----------
>  drivers/gpio/gpio-stp-xway.c | 10 ++--------
>  drivers/gpio/gpio-zynq.c     | 10 +---------
>  3 files changed, 5 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c

I already sent a patch like that for davinci, please drop that part.
Please split the other two into their separate per-driver patches.

Bart