linux-kernel - Re: [PATCH] ipmi:ssif: Exit early when there is a SMBus error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240820102005.4l2j73jpt7lmwloh@localhost.localdomain>
Date: Tue, 20 Aug 2024 13:20:05 +0300
From: "Ivan T. Ivanov" <iivanov@...e.de>
To: corey@...yard.net
Cc: minyard@....org, openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi:ssif: Exit early when there is a SMBus error

On 08-18 12:27, Ivan T. Ivanov wrote:
> 
> > 
> > 3) It appears the response to the GET_DEVICE_ID command, though a
> > response is returned, is not valid.  The right way to handle this would
> > be to do more validation in the ssif_detect() function.  It doesn't do
> > any validation of the response data, and that's really what needs to be
> > done.
> > 
> 
> do_cmd() in ssif_detect() already do validation. Perhaps,
> ssif_probe() should just not return ENODEV in case of error.
> 

Oh, I wanted to say ssif_detect, not ssif_probe. 

Regards,
Ivan