linux-kernel - RE: [PATCH v6 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <087301daf2a2$c64deb70$52e9c250$@samsung.com>
Date: Tue, 20 Aug 2024 10:46:28 +0900
From: "sunyeal.hong" <sunyeal.hong@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>
Cc: "'Sylwester Nawrocki'" <s.nawrocki@...sung.com>, "'Chanwoo Choi'"
	<cw00.choi@...sung.com>, "'Alim Akhtar'" <alim.akhtar@...sung.com>,
	"'Michael	Turquette'" <mturquette@...libre.com>, "'Stephen Boyd'"
	<sboyd@...nel.org>, "'Rob	Herring'" <robh@...nel.org>, "'Conor Dooley'"
	<conor+dt@...nel.org>, <linux-samsung-soc@...r.kernel.org>,
	<linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU
 bindings

Hello Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Monday, August 19, 2024 5:20 PM
> To: Sunyeal Hong <sunyeal.hong@...sung.com>
> Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>; Chanwoo Choi
> <cw00.choi@...sung.com>; Alim Akhtar <alim.akhtar@...sung.com>; Michael
> Turquette <mturquette@...libre.com>; Stephen Boyd <sboyd@...nel.org>; Rob
> Herring <robh@...nel.org>; Conor Dooley <conor+dt@...nel.org>; linux-
> samsung-soc@...r.kernel.org; linux-clk@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v6 1/4] dt-bindings: clock: add ExynosAuto v920 SoC
> CMU bindings
> 
> On Mon, Aug 19, 2024 at 02:24:12PM +0900, Sunyeal Hong wrote:
> > Add dt-schema for ExynosAuto v920 SoC clock controller.
> > Add device tree clock binding definitions for below CMU blocks.
> >
> > - CMU_TOP
> > - CMU_PERIC0
> >
> > Signed-off-by: Sunyeal Hong <sunyeal.hong@...sung.com>
>  +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: External reference clock (38.4 MHz)
> > +            - description: CMU_PERIC0 NOC clock (from CMU_TOP)
> > +            - description: CMU_PERIC0 IP clock (from CMU_TOP)
> > +
> > +        clock-names:
> > +          items:
> > +            - const: oscclk
> > +            - const: noc
> > +            - const: ip
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: samsung,exynosautov920-cmu-peric1
> > +
> > +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: External reference clock (38.4 MHz)
> > +            - description: CMU_PERIC1 NOC clock (from CMU_TOP)
> > +            - description: CMU_PERIC1 IP clock (from CMU_TOP)
> > +
> > +        clock-names:
> > +          items:
> > +            - const: oscclk
> > +            - const: noc
> > +            - const: ip
> 
> This is the same peric0, so combine them and clocks could be just:
> 
> items:
>   - description: External reference clock (38.4 MHz)
>   - description: CMU_PERICn NOC clock (from CMU_TOP)
>   - description: CMU_PERICn IP clock (from CMU_TOP)
> 

As you reviewed, I will remove the duplicates.

> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: samsung,exynosautov920-cmu-misc
> > +
> > +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: External reference clock (38.4 MHz)
> > +            - description: CMU_MISC NOC clock (from CMU_MISC)
> 
> Similarly:
> 
> - description: CMU_MISC/CMU_HSI0 NOC clock (from CMU_MISC)

Best Regards,
sunyeal