linux-kernel - Re: [PATCH v2 2/2] cpuidle: riscv-sbi: Simplify with scoped for each OF child loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhSdy00N62pZfMrBTMASaZUqW6L-zEe_BqNZ4ZsOWdEvxHDZA@mail.gmail.com>
Date: Tue, 20 Aug 2024 16:29:48 +0530
From: Anup Patel <anup@...infault.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, 
	Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Atish Patra <atishp@...osinc.com>, linux-pm@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v2 2/2] cpuidle: riscv-sbi: Simplify with scoped for each
 OF child loop

On Tue, Aug 20, 2024 at 3:10 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> Use scoped for_each_child_of_node_scoped() when iterating over device
> nodes to make code a bit simpler.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

LGTM.

Reviewed-by: Anup Patel <anup@...infault.org>

Regards,
Anup

>
> ---
>
> Changes in v2:
> 1. None, only Rb tag.
>
> Other patches from the set were applied.
> ---
>  drivers/cpuidle/cpuidle-riscv-sbi.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-riscv-sbi.c b/drivers/cpuidle/cpuidle-riscv-sbi.c
> index 5bb3401220d2..d228b4d18d56 100644
> --- a/drivers/cpuidle/cpuidle-riscv-sbi.c
> +++ b/drivers/cpuidle/cpuidle-riscv-sbi.c
> @@ -448,7 +448,6 @@ static void sbi_pd_remove(void)
>
>  static int sbi_genpd_probe(struct device_node *np)
>  {
> -       struct device_node *node;
>         int ret = 0, pd_count = 0;
>
>         if (!np)
> @@ -458,13 +457,13 @@ static int sbi_genpd_probe(struct device_node *np)
>          * Parse child nodes for the "#power-domain-cells" property and
>          * initialize a genpd/genpd-of-provider pair when it's found.
>          */
> -       for_each_child_of_node(np, node) {
> +       for_each_child_of_node_scoped(np, node) {
>                 if (!of_property_present(node, "#power-domain-cells"))
>                         continue;
>
>                 ret = sbi_pd_init(node);
>                 if (ret)
> -                       goto put_node;
> +                       goto remove_pd;
>
>                 pd_count++;
>         }
> @@ -480,8 +479,6 @@ static int sbi_genpd_probe(struct device_node *np)
>
>         return 0;
>
> -put_node:
> -       of_node_put(node);
>  remove_pd:
>         sbi_pd_remove();
>         pr_err("failed to create CPU PM domains ret=%d\n", ret);
> --
> 2.43.0
>