linux-kernel - Re: [PATCH v2 1/2] cpuidle: riscv-sbi: Use scoped device node handling to fix missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i7kweDVUGw103kq7kPOoh+9vJMU_8xugHA_hqqkRdaNg@mail.gmail.com>
Date: Tue, 20 Aug 2024 21:49:21 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Anup Patel <anup@...infault.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
	Atish Patra <atishp@...osinc.com>, linux-pm@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] cpuidle: riscv-sbi: Use scoped device node
 handling to fix missing of_node_put

On Tue, Aug 20, 2024 at 12:57 PM Anup Patel <anup@...infault.org> wrote:
>
> On Tue, Aug 20, 2024 at 3:10 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
> >
> > Two return statements in sbi_cpuidle_dt_init_states() did not drop the
> > OF node reference count.  Solve the issue and simplify entire error
> > handling with scoped/cleanup.h.
> >
> > Fixes: 6abf32f1d9c5 ("cpuidle: Add RISC-V SBI CPU idle driver")
> > Cc: <stable@...r.kernel.org>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> LGTM.
>
> Reviewed-by: Anup Patel <anup@...infault.org>

Applied along with the [2/2] as 6.12 material, thanks!