[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZsR5KPxo-l9_7p0X@ashyti-mobl2.lan>
Date: Tue, 20 Aug 2024 13:08:24 +0200
From: Andi Shyti <andi.shyti@...ux.intel.com>
To: Yu Jiaoliang <yujiaoliang@...o.com>
Cc: Jani Nikula <jani.nikula@...ux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Tvrtko Ursulin <tursulin@...ulin.net>,
David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Matt Roper <matthew.d.roper@...el.com>,
Andi Shyti <andi.shyti@...ux.intel.com>,
Michal Mrozek <michal.mrozek@...el.com>,
Lucas De Marchi <lucas.demarchi@...el.com>,
Tejas Upadhyay <tejas.upadhyay@...el.com>,
Gustavo Sousa <gustavo.sousa@...el.com>,
Shekhar Chauhan <shekhar.chauhan@...el.com>,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, opensource.kernel@...o.com,
Jani Nikula <jani.nikula@...el.com>
Subject: Re: [PATCH v2] drm/i915/gt: Use kmemdup_array instead of kmemdup for
multiple allocation
Hi,
On Tue, Aug 20, 2024 at 05:53:02PM +0800, Yu Jiaoliang wrote:
> Let the kememdup_array() take care about multiplication and possible
> overflows.
>
> v2:
> - Change subject
> - Leave one blank line between the commit log and the tag section
> - Fix code alignment issue
>
> Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>
> Reviewed-by: Jani Nikula <jani.nikula@...el.com>
> Reviewed-by: Andi Shyti <andi.shyti@...ux.intel.com>
I didn't give you an explicit R-b, but that's fine, you can keep
it as I think the patch is fine.
> - struct i915_wa *list = kmemdup_array(wal->list,
> - wal->count, sizeof(*list),
> - GFP_KERNEL);
> + struct i915_wa *list = kmemdup_array(wal->list, wal->count,
> + sizeof(*list), GFP_KERNEL);
Do you see the indentation is off here? :-)
Please, run checkpatch.pl before sending the patch, as well.
Besides, what patch is this? Are you replacing kmemdup_array with
kmemdup_array? This v2 applies on your v1 while it should apply
on a clean drm-tip repository.
Thanks,
Andi
>
> if (list) {
> kfree(wal->list);
> --
> 2.34.1
Powered by blists - more mailing lists