linux-kernel - Re: [PATCH v2] drm/i915/gt: Use kmemdup_array instead of kmemdup for multiple allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ngzckr4tdknp73oki6ig7drg6vx5hapqz3226ejfuhah5khefh@6gwnuk4q2nlx>
Date: Tue, 20 Aug 2024 07:53:10 -0500
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: Yu Jiaoliang <yujiaoliang@...o.com>
CC: Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Tvrtko Ursulin <tursulin@...ulin.net>, David Airlie <airlied@...il.com>,
	Daniel Vetter <daniel@...ll.ch>, Matt Roper <matthew.d.roper@...el.com>,
	"Andi Shyti" <andi.shyti@...ux.intel.com>, Michal Mrozek
	<michal.mrozek@...el.com>, Tejas Upadhyay <tejas.upadhyay@...el.com>, Gustavo
 Sousa <gustavo.sousa@...el.com>, Shekhar Chauhan <shekhar.chauhan@...el.com>,
	<intel-gfx@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, <opensource.kernel@...o.com>, Jani Nikula
	<jani.nikula@...el.com>
Subject: Re: [PATCH v2] drm/i915/gt: Use kmemdup_array instead of kmemdup for
 multiple allocation

On Tue, Aug 20, 2024 at 05:53:02PM GMT, Yu Jiaoliang wrote:
>Let the kememdup_array() take care about multiplication and possible
>overflows.
>
>v2:
>- Change subject
>- Leave one blank line between the commit log and the tag section
>- Fix code alignment issue
>
>Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>
>Reviewed-by: Jani Nikula <jani.nikula@...el.com>
>Reviewed-by: Andi Shyti <andi.shyti@...ux.intel.com>
>---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>index d90348c56765..0fcfd55c62b4 100644
>--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>@@ -111,9 +111,8 @@ static void wa_init_finish(struct i915_wa_list *wal)
> {
> 	/* Trim unused entries. */
> 	if (!IS_ALIGNED(wal->count, WA_LIST_CHUNK)) {
>-		struct i915_wa *list = kmemdup_array(wal->list,

					^

it was already kmemdup_array, not kmemdup. Am I missing anything?

Lucas De Marchi

>-					       wal->count, sizeof(*list),
>-					       GFP_KERNEL);
>+		struct i915_wa *list = kmemdup_array(wal->list, wal->count,
>+											 sizeof(*list), GFP_KERNEL);
>
> 		if (list) {
> 			kfree(wal->list);
>-- 
>2.34.1
>