linux-kernel - Re: [PATCH] memory: mtk-smi: Simplify using devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <101f33d8-9bb9-4722-9a6a-718394246b70@kernel.org>
Date: Tue, 20 Aug 2024 14:40:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rong Qianfeng <rongqianfeng@...o.com>, Yong Wu <yong.wu@...iatek.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH] memory: mtk-smi: Simplify using devm_clk_get_enabled()

On 20/08/2024 14:34, Rong Qianfeng wrote:
> devm_clk_get_enabled() will call devm_clk_get() + clk_prepare_enable()
> and the clock will automatically be disabled, unprepared and freed when
> the device is unbound from the bus. 

That's obvious, drop. You do not have to explain basic APIs. Instead say
what is being simplified here.

> So simplify mtk_smi_common_probe()
> accordingly.

Also explain that you fix bug of missing unprepare in unbind and add
Fixes+CC stable tags.

Best regards,
Krzysztof