linux-kernel - Re: [PATCH] memory: mtk-smi: Simplify using devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53745cad-b586-4467-8fbb-bb3d47e66d97@vivo.com>
Date: Wed, 21 Aug 2024 10:02:09 +0800
From: Rong Qianfeng <11065417@...o.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Rong Qianfeng <rongqianfeng@...o.com>
Cc: opensource.kernel@...o.com, Yong Wu <yong.wu@...iatek.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH] memory: mtk-smi: Simplify using devm_clk_get_enabled()


在 2024/8/20 20:40, Krzysztof Kozlowski 写道:
> [Some people who received this message don't often get email from krzk@...nel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On 20/08/2024 14:34, Rong Qianfeng wrote:
>> devm_clk_get_enabled() will call devm_clk_get() + clk_prepare_enable()
>> and the clock will automatically be disabled, unprepared and freed when
>> the device is unbound from the bus.
> That's obvious, drop. You do not have to explain basic APIs. Instead say
> what is being simplified here.
>
>> So simplify mtk_smi_common_probe()
>> accordingly.
> Also explain that you fix bug of missing unprepare in unbind and add
> Fixes+CC stable tags.

OK, thanks for the reminder.

Best regards,

Qianfeng

>
> Best regards,
> Krzysztof
>