linux-kernel - Re: [PATCH v4] hid-playstation: DS4: Update rumble and lightbar together

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEc3jaD6sv=O+MbH5XtHvpXgXyzBROfLDYX2rGoa+3QCOJ-Srw@mail.gmail.com>
Date: Wed, 21 Aug 2024 08:03:42 -0700
From: Roderick Colenbrander <thunderbird2k@...il.com>
To: Jiri Kosina <jikos@...nel.org>
Cc: Max Staudt <max@...as.org>, Roderick Colenbrander <roderick.colenbrander@...y.com>, 
	Benjamin Tissoires <benjamin.tissoires@...hat.com>, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] hid-playstation: DS4: Update rumble and lightbar together

On Wed, Aug 21, 2024 at 7:33 AM Jiri Kosina <jikos@...nel.org> wrote:
>
> On Tue, 20 Aug 2024, Max Staudt wrote:
>
> > Some 3rd party gamepads expect updates to rumble and lightbar together,
> > and setting one may cancel the other.
> >
> > Let's maximise compatibility for these controllers by sending rumble
> > and lightbar updates together, even when only one has been scheduled.
> >
> > The quirky controllers are matched by a known CRC32 over their HID
> > report descriptor (hdev->rdesc), since they seem to share the same
> > descriptor, while pretending to be a Sony DS4 v2.0.
> >
> > Signed-off-by: Max Staudt <max@...as.org>
>
> Roderick, does you Ack from v2 still hold?

Ideally I would like some type of quirk, but I have no good way of
verifying (also across different 'clone' devices) how reliable this
current check would be. It feels a bit too much towards a magical
value. I don't see why the reports would differ besides some engineer
having made a typo.

My gut feeling is that the previous fix is less fragile, so let's opt
for that one.

Roderick

>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
>