linux-kernel - Re: [PATCH v4] hid-playstation: DS4: Update rumble and lightbar together

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b58bf46-503e-48c6-ad1c-e54a5c13e7a2@enpas.org>
Date: Wed, 21 Aug 2024 17:22:28 +0200
From: Max Staudt <max@...as.org>
To: Roderick Colenbrander <thunderbird2k@...il.com>,
 Jiri Kosina <jikos@...nel.org>
Cc: Roderick Colenbrander <roderick.colenbrander@...y.com>,
 Benjamin Tissoires <benjamin.tissoires@...hat.com>,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] hid-playstation: DS4: Update rumble and lightbar
 together

On 8/21/24 17:03, Roderick Colenbrander wrote:
> Ideally I would like some type of quirk, but I have no good way of
> verifying (also across different 'clone' devices) how reliable this
> current check would be. It feels a bit too much towards a magical
> value. I don't see why the reports would differ besides some engineer
> having made a typo.

The descriptors differ in several ways - why, I don't know.


  - Across a few DS4 2.0 that I have looked at, they seemed to all have 
the same descriptors.

  - Quite a few clones seemed to expose the exact same descriptor on 
USB, and those didn't need this quirk either.

  - I have seen two controllers that need this quirk, and they both have 
the *same* descriptor, which is close to, but still notably different 
from, the DS4 v2.0 descriptor.


So, while I don't have a large base to infer from, it seems like this 
particular "magic" descriptor and the quirk are correlated.


Do you have another idea for a specific enough difference that I could 
look for?


> My gut feeling is that the previous fix is less fragile, so let's opt
> for that one.

Let me know if you wish for me to resend v2 with a Signed-off-by. Or, I 
guess Jiri might just manually patch it in - please see this as 
permission to do so if you prefer this.



Max