linux-kernel - Re: [Upstream] [PATCH] arm64: dts: imx8mp-phyboard-pollux-rdk: Add support for PCIe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88eff780-b029-459f-9ac4-2b9779f47929@phytec.de>
Date: Wed, 21 Aug 2024 15:23:39 +0000
From: Benjamin Hahn <B.Hahn@...tec.de>
To: Yannic Moog <Y.Moog@...tec.de>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "robh@...nel.org"
	<robh@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, Teresa Remmet <T.Remmet@...tec.de>
CC: "imx@...ts.linux.dev" <imx@...ts.linux.dev>, PHYTEC Upstream
	<upstream@...ts.phytec.de>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [Upstream] [PATCH] arm64: dts: imx8mp-phyboard-pollux-rdk: Add
 support for PCIe

Hi Yannic,

On 20.08.24 10:52, Yannic Moog wrote:
> Hello Benjamin,
>
> On Tue, 2024-08-13 at 14:02 +0200, Benjamin Hahn wrote:
>> Add support for the Mini PCIe slot.
>>
>> Signed-off-by: Benjamin Hahn <B.Hahn@...tec.de>
>> ---
>>   .../dts/freescale/imx8mp-phyboard-pollux-rdk.dts   | 42 ++++++++++++++++++++++
>>   1 file changed, 42 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
>> b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
>> index 00a240484c25..0ecb2f62c37f 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
>> @@ -6,6 +6,7 @@
>>   
>>   /dts-v1/;
>>   
>> +#include <dt-bindings/phy/phy-imx8-pcie.h>
>>   #include <dt-bindings/leds/leds-pca9532.h>
>>   #include <dt-bindings/pwm/pwm.h>
>>   #include "imx8mp-phycore-som.dtsi"
>> @@ -63,6 +64,17 @@ reg_can2_stby: regulator-can2-stby {
>>   		regulator-name = "can2-stby";
>>   	};
>>   
>> +	reg_pcie0: regulator-pcie {
>> +		compatible = "regulator-fixed";
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_pcie0_reg>;
>> +		regulator-name = "MPCIE_3V3";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		gpio = <&gpio1 14 GPIO_ACTIVE_HIGH>;
>> +		enable-active-high;
>> +	};
>> +
> pcie uses the reg_vcc_3v3_sw. Drop this node and use the appropriate regulator instead.
ok
>
>>   	reg_lvds1_reg_en: regulator-lvds1 {
>>   		compatible = "regulator-fixed";
>>   		enable-active-high;
>> @@ -195,6 +207,23 @@ &snvs_pwrkey {
>>   	status = "okay";
>>   };
>>   
>> +&pcie_phy {
>> +	fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_OUTPUT>;
>> +	fsl,clkreq-unsupported;
> Why do you have this as unsupported? We have a GPIO connected to CLKREQ.
It looks like the pcie driver does not support using a GPIO for clkreq. 
So it does not work for us.
>
>> +	clocks = <&hsio_blk_ctrl>;
>> +	clock-names = "ref";
>> +	status = "okay";
>> +};
>> +
>> +/* Mini PCIe */
>> +&pcie {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_pcie0>;
>> +	reset-gpio = <&gpio1 8 GPIO_ACTIVE_LOW>;
>> +	vpcie-supply = <&reg_pcie0>;
>> +	status = "okay";
>> +};
>> +
>>   &pwm3 {
>>   	status = "okay";
>>   	pinctrl-names = "default";
>> @@ -366,6 +395,19 @@ MX8MP_IOMUXC_SD2_WP__GPIO2_IO20		0x12
>>   		>;
>>   	};
>>   
>> +	pinctrl_pcie0: pcie0grp {
>> +		fsl,pins = <
>> +			MX8MP_IOMUXC_GPIO1_IO11__GPIO1_IO11	0x60 /* open drain, pull up */
>> +			MX8MP_IOMUXC_GPIO1_IO08__GPIO1_IO08	0x40
> Can you please reorder numerically ascending?
> You are missing GPIO1 10 used for WAKE#.

ok

Benjamin

>
>> +		>;
>> +	};
>> +
>> +	pinctrl_pcie0_reg: pcie0reggrp {
>> +		fsl,pins = <
>> +			MX8MP_IOMUXC_GPIO1_IO14__GPIO1_IO14	0x40
> This gpio muxing should be in the pcie0grp.
>
> Yannic
>
>> +		>;
>> +	};
>> +
>>   	pinctrl_pwm3: pwm3grp {
>>   		fsl,pins = <
>>   			MX8MP_IOMUXC_SPDIF_TX__PWM3_OUT		0x12
>>
>> ---
>> base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba
>> change-id: 20240813-wip-bhahn-add_pcie_support-b9bd75fc4d98
>>
>> Best regards,